fwcd / fwcd/kotlin-language-server

Consider increasing MAX_FQNAME_LENGTH

Open
#575 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Kotlin
Stars
2k
Forks
252
PR merge metrics
No merged PRs in 30d

Description

When resolving classpath I got the following message:
```
Could not resolve classpath using Cached + (Stdlib + ([] or (((((([] + Maven) + Gradle) + Shell) + Maven) + Gradle) + Shell)) or Backup): Value '/home/..../258-char-long-path/..../....jar' can't be stored to database column because exceeds length (255)"
```

Would it be possible to increase the length of [`MAX_FQNAME_LENGTH`](https://github.com/fwcd/kotlin-language-server/blob/bdba774daa2f4113a723b7a2d07d696be3b563cf/server/src/main/kotlin/org/javacs/kt/index/SymbolIndex.kt#L19) to something larger than 255, for example 511 or 1023? Any negative impact of doing so?

I can open a PR if necessary.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start in server/src/main/kotlin/org/javacs/kt/index/SymbolIndex.kt at MAX_FQNAME_LENGTH, then trace how the value is stored in the database column. Check the classpath-resolution path that produces the 255-character failure and determine whether increasing the limit avoids it without storage-side problems; done means long classpath values can be stored and resolved successfully.

Written by the indexing model from the issue text.

Assessment

Tech stack
kotlin
Domain
databases
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.