Beta lane hardcodes configuration: "Beta", preventing customization

Open Beginner friendly
#2 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
62/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Quiet
Tech stack
ios
Domain
ci-cd, mobile, release

Research direction

The issue names the beta lane and its build_ios_app call; start there and inspect how build_settings receives ADDITIONAL_BUILD_SETTINGS. Verify the configuration precedence through the repository's existing CI or Fastlane flow. Done means a custom configuration can be selected while Beta remains the default.

Written by the indexing model from the issue text.

Description

Problem

The beta lane hardcodes configuration: "Beta" in build_ios_app, which overrides any configuration set via ENV["ADDITIONAL_BUILD_SETTINGS"]:

build_ios_app(build_settings.merge({
  configuration: "Beta"
}))

The .merge() overwrites any configuration key from ADDITIONAL_BUILD_SETTINGS, forcing projects to override the entire lane to use a different build configuration.

Suggested fix

Allow override via ENV while keeping "Beta" as default:

build_ios_app(build_settings.merge({
  configuration: ENV["BETA_CONFIGURATION"] || "Beta"
}))

Or let build_settings (which respects ADDITIONAL_BUILD_SETTINGS) be the source of truth by only setting configuration if not already present.

Migrated from futuredapp/fastlane#213

Dominant language
Python
Stars
0
Forks
0
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.