fusion44 / fusion44/blitz_api

Properly handle invalid Redis DB arguments

Open
#221 1 comment 0 reactions 0 assignees View on GitHub
bug v0.6.0-beta
Dominant language
Python
Stars
25
Forks
19
PR merge metrics
No merged PRs in 30d

Description

When starting the API with an invalid Redis DB it'll go in an infinite loop. The Redis DB is a hard requirement and thus the API should stop when encountering this error.

```
2023-07-09 17:55:07 | ℹ️ | logging.py:87 | Waiting for application startup.
2023-07-09 17:55:07 | ❌ | logging.py:87 | Traceback (most recent call last):
File "/usr/local/lib/python3.9/site-packages/starlette/routing.py", line 677, in lifespan
async with self.lifespan_context(app) as maybe_state:
File "/usr/local/lib/python3.9/site-packages/starlette/routing.py", line 566, in __aenter__
await self._router.startup()
File "/usr/local/lib/python3.9/site-packages/starlette/routing.py", line 654, in startup
await handler()
File "/code/./app/main.py", line 96, in on_startup
await redis_plugin.init()
File "/usr/local/lib/python3.9/site-packages/fastapi_plugins/_redis.py", line 197, in init
await self.ping()
File "/usr/local/lib/python3.9/site-packages/fastapi_plugins/_redis.py", line 217, in ping
return await self.redis.ping()
File "/usr/local/lib/python3.9/site-packages/redis/asyncio/client.py", line 526, in execute_command
conn = self.connection or await pool.get_connection(command_name, **options)
File "/usr/local/lib/python3.9/site-packages/redis/asyncio/connection.py", line 1404, in get_connection
await connection.connect()
File "/usr/local/lib/python3.9/site-packages/redis/asyncio/connection.py", line 622, in connect
await self.on_connect()
File "/usr/local/lib/python3.9/site-packages/redis/asyncio/connection.py", line 724, in on_connect
if str_if_bytes(await self.read_response()) != "OK":
File "/usr/local/lib/python3.9/site-packages/redis/asyncio/connection.py", line 868, in read_response
raise response from None
redis.exceptions.ResponseError: DB index is out of range

2023-07-09 17:55:07 | ❌ | logging.py:87 | Application startup failed. Exiting.
```

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.