funilrys / funilrys/PyFunceble

Feature Request | Move the Special Rules list

Open
#409 2 comments 0 reactions 1 assignee Claimed by @funilrys View on GitHub
enhancement
Dominant language
Python
Stars
347
Forks
43
PR merge metrics
No merged PRs in 30d

Description

### What is the feature you'd like to request?

I suggest we moves the rules.py contests of:

https://github.com/funilrys/PyFunceble/blob/8eb12e9ce06ebc4921c3f5efaf15cee152f9fbae/PyFunceble/checker/availability/extras/rules.py#L79-L114

As this is plain json, I suggest this part is giving it's own branch or REPO to avoid waiting to long for updates, You should grant a number of users moderator rights on this files AND the requirements of two moderators approval before it's merge able.

This can remove the stalled time and properly a lot of merge issues such as https://github.com/funilrys/PyFunceble/pull/404

### What problem are you trying to solve?

I'm trying to solve a problem where...

### What solution would you like to see?

A single point of "failure" awaiting a single users approval, for something that should be rather flexible for a number of trusted users to merge and maintain, and this list should not be depending on the rest of the pyfunceble project + is can be shared to other project.

### Are there any alternatives you've considered?

I've considered alternatives such as...

### Additional context

This JSON file should be a JSON5 file, to allow adding comments inside the file, for easier maintenance.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.