funcool / funcool/struct

A mismatch of the strip option in the validate API

Open
#24 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Clojure
Stars
116
Forks
15
PR merge metrics
No merged PRs in 30d

Description

Hi, funcool. Thank you for your creating nice validation library.

I've found a mismatch between document and its work.

`validate` API's comment says,
> This function by default strips all data that are not defined in
> schema, but this behavior can be changed by passing `{:strip false}`
> as third argument.

but actually default value of strip is false.
https://github.com/funcool/struct/blob/master/src/struct/core.cljc#L129

Which have you intended?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.