funcool / funcool/buddy-sign

Potentially pointless salt

Open
#95 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Clojure
Stars
135
Forks
46
PR merge metrics
No merged PRs in 30d

Description

I was looking at this:

https://github.com/funcool/buddy-sign/blob/master/src/buddy/sign/compact.clj#L118

What is the purpose of salt here? The only possible use for salt I could imagine is to use it as a nonce,
by storing the salts you've received recently, as to prevent replay attacks. But the unsign function doesn't really expose it, so
you need to cut it out yourself from the string. Otherwise this adds no security, the HMAC and other signing algos are secure as is.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.