funcool / funcool/bide

Support for anchor tag - currently pollutes results

Open
#10 3 comments 1 reaction 0 assignees View on GitHub
bug help wanted
Dominant language
JavaScript
Stars
132
Forks
17
PR merge metrics
No merged PRs in 30d

Description

Love the library. Very simple to use. Did run into issues with anchors. if they are on the path then they leak into the produced results.

`(def routes [["/" :root] ["/:id" :root-with-id]])`
`(def my-router (r/router routes))`
`(r/match my-router "/") ; [:root nil nil]`
`(r/match my-router "/?a=1") ; [:root nil {:a "1"}]`
`(r/match my-router "/?a=1#asdf") ; [:root nil {:a "1#asdf"}]`
`(r/match my-router "/#asdf") ; [:root-with-id {:id "#asdf"} nil]`
`(r/match my-router "/my-id#asdf") ; [:root-with-id {:id "my-id#asdf"} nil]`
`(r/match my-router "/my-id?a=1#asdf") ; [:root-with-id {:id "my-id"} {:a "1#asdf"}]`

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.