fullstorydev / fullstorydev/grpcurl

With an UnaryResponse, OnReceiveResponse is never called

Open
#429 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
12.8k
Forks
580
Avg merge
1h 8m
Merged PRs (30d)
5

Description

Version used :
* github.com/fullstorydev/grpcurl 1.8.9
* google.golang.org/grpc 1.59.0

I am using grpcurl as a library and I discover that the call to OnReceiveResponse of the EventHandler is not called even when there is a success on the grpc call .
When digging in the code, it should be called here : https://github.com/fullstorydev/grpcurl/blob/master/invoke.go#L175-L186
In the google.golang.org/grpc, the function status.FromError has a difference between its documented contract and the actual contract when there is no error :
* Documented contract : https://github.com/grpc/grpc-go/blob/v1.59.0/status/status.go#L85-L86
* Real contract : https://github.com/grpc/grpc-go/blob/v1.59.0/status/status.go#L97-L99
since https://github.com/grpc/grpc-go/commit/5da5b1f225a310a6e36fe01fb7e0883e04cda2e0 (so since version 1.52.2)

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.