fullstorydev / fullstorydev/grpcurl

Support for PROTOCOL_BUFFERS_PYTHON_IMPLEMENTATION

Open
#356 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
12.8k
Forks
580
Avg merge
1h 8m
Merged PRs (30d)
5

Description

In our code, we use `os.environ["PROTOCOL_BUFFERS_PYTHON_IMPLEMENTATION"] = "python"`
Because of this, float arrays sent with `grpcurl` are converted into double, i could be wrong on this.
In any case, adding this extra casting code is solving that, but still, it would be better if we could provide additional option to how grpcurl would handle casting implementation.

```
arr = np.array(request.user_ids)
user_ids = arr.astype(np.float)
```

Contributor guide

No contributing guide indexed for this repository

Research direction

The issue does not name any files or tests. Start by locating grpcurl's handling of PROTOCOL_BUFFERS_PYTHON_IMPLEMENTATION and float-array values, then determine how a command-line option could control casting behavior. Done means the requested implementation choice is configurable and float arrays are handled as intended.

Written by the indexing model from the issue text.

Assessment

Tech stack
go, grpc
Domain
cli
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.