fullstorydev / fullstorydev/grpcurl

Proto import file globs

Open
#339 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
12.8k
Forks
580
Avg merge
1h 8m
Merged PRs (30d)
5

Description

Perhaps to satisfy some use cases like error handling conventions in #238, could file globs be supported? Assuming someone doesn't have file naming it would be a lot easier to use something like `--protos .:my_org/**/*.proto --protos ./third_party:**/*.proto` than listing individual proto files to do things like reflect on custom error details. The order of `protos` parameter would determine the lookup priority if there are any naming conflicts.

My use case would be checking in all third party protos like those from https://github.com/googleapis/api-common-protos into `./third_party` and be able to use the convention where things like `FieldViolation` is returned in gRPC errors.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start at the --protos option and trace the existing proto file lookup and import handling. Check how multiple proto paths are currently prioritized; done means glob patterns work for the shown path forms and preserve the stated lookup priority when names conflict.

Written by the indexing model from the issue text.

Assessment

Tech stack
go, grpc
Domain
api, cli
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.