fullstorydev / fullstorydev/grpcurl

How to serialize using protojson

Open
#305 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
12.8k
Forks
580
Avg merge
1h 8m
Merged PRs (30d)
5

Description

The jsonpb package has been discarded and protojson is recommended, but I found that protojson is not compatible with grpcurl. Is it considered to replace it with protojson?
https://github.com/golang/protobuf/blob/master/jsonpb/json.go
```
// Copyright 2015 The Go Authors. All rights reserved.
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.

// Package jsonpb provides functionality to marshal and unmarshal between a
// protocol buffer message and JSON. It follows the specification at
// https://developers.google.com/protocol-buffers/docs/proto3#json.
//
// Do not rely on the default behavior of the standard encoding/json package
// when called on generated message types as it does not operate correctly.
//
// Deprecated: Use the "google.golang.org/protobuf/encoding/protojson"
// package instead.
```

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with the referenced jsonpb/json.go and compare its documented replacement, google.golang.org/protobuf/encoding/protojson, against grpcurl's current serialization behavior. Done means determining whether protojson is compatible and recording or implementing a clear migration decision for grpcurl.

Written by the indexing model from the issue text.

Assessment

Tech stack
go, grpc
Domain
api, cli
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.