fullstorydev / fullstorydev/grpcui

Incompatible with validators

Open
#46 6 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
5.9k
Forks
427
Avg merge
3d 6h
Merged PRs (30d)
7

Description

Tested with both `github.com/mwitkow/go-proto-validators` and `github.com/envoyproxy/protoc-gen-validate/`, it all failed with `File not found` errors.

This is caused by these validators lib not registering themselves into reflection. However, these protos are used in field/method options, and in fact not actual dependencies to make the GRPC call.

Our current workaround is to [fork](https://github.com/hoveychen/grpcui) the underlying project `jhump/protoreflect`, and provide an opt-out option to ignore failure to reflect these lib.

Looking forward to a better solution.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.