fullstorydev / fullstorydev/grpcui

[Feature Request] Forward specified headers between GRPC backend and web UI

Open
#438 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
5.9k
Forks
427
Avg merge
3d 6h
Merged PRs (30d)
7

Description

I want to set the login session for an RPC server in a cookie which would require forwarding the Set-Cookie and Cookie headers from the GRPC backend to the web UI.

If I were to make a pull request implementing this, would it likely be accepted?

## Some Implementation options

1. Rename `PreserveHeaders` in [InvokeOptions](https://github.com/fullstorydev/grpcui/blob/master/handlers.go#L50) to `PreserveRequestHeaders` and add a similar `PreserveResponseHeaders` field (which can be set in the same way)
2. Add a `PreserveResponseHeaders` without renaming `PreserveHeaders`
* Leaning for this option since it has minimal effect on existing use cases
4. Apply the existing `PreserveHeaders` to both request and response headers

Contributor guide

No contributing guide indexed for this repository

Research direction

Start in handlers.go at InvokeOptions and trace how PreserveHeaders is applied to request and response metadata. Compare the listed options with existing header-forwarding behavior; done means the chosen API forwards Cookie and Set-Cookie headers between the gRPC backend and web UI without disrupting existing uses.

Written by the indexing model from the issue text.

Assessment

Tech stack
go, grpc
Domain
api, frontend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.