asyncssh API change breaks parsing of config
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 89
- Forks
- 21
- PR merge metrics
- No merged PRs in 30d
Description
The v2.19.0 release of asyncssh has added support for hostname canonicalization. With this change, two new arguments were added to SSHClientConfig.load: canonical and final. We should also pass these parameters in sshfs, because right now the local_user and user are passed in their places, which breaks parsing the config in config.py:
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in sshfs/config.py at lines 23-31 and compare the SSHClientConfig.load call with asyncssh/config.py lines 428-430 for the v2.19.0 signature. Verify that configuration parsing no longer misassigns local_user and user, using the repository's existing checks if available. Done means sshfs parses the config correctly with asyncssh v2.19.0.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- networking
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 48/100