synchronous `rmdir()` fails silently
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 89
- Forks
- 21
- PR merge metrics
- No merged PRs in 30d
Description
Hello.
Trying to remove directories using SSHFileSystem via rmdir fails silently.
Appears to be missing the synchronous wrapper for _rmdir. i.e. the equivalent of: mkdir = sync_wrapper(_mkdir) and thus ends up all the way in AbstractFileSystem.rmdir which is implemented as pass # not necessary to implement, may not have directories.
A local test of adding the sync_wrapper works ok so far.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in the SSHFileSystem implementation and compare the synchronous rmdir path with the existing _rmdir and sync_wrapper patterns, including the fallback in AbstractFileSystem.rmdir. Reproduce the silent failure locally, then add the missing synchronous behavior and verify that directory removal succeeds.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100