fsspec / fsspec/s3fs

`find` includes the parent folder name

Open
#799 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
1k
Forks
305
Avg merge
22h 37m
Merged PRs (30d)
4

Description

At least since version 2023.9 s3fs.S3FileSystem().find(...) includes the folder that it searches in. This is a breaking change with previous behavior and also possibly introduces bugs in the completely valid case of having a subfolder with the same name as the folder to search in, for example for exhaustive iteration.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue with s3fs.S3FileSystem().find(...) on a folder that contains a same-named subfolder, and compare the result with the prior behavior described in the report. Done means the searched parent folder is not included while valid matching descendants, including a same-named subfolder, remain discoverable.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
cloud
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.