Re-creating a bucket when it already exists in _mkdir [BUG]
Open
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 1k
- Forks
- 305
- Avg merge
- 22h 37m
- Merged PRs (30d)
- 4
Description
https://github.com/fsspec/s3fs/blob/3e9b7d4a62f6efb3d282d9ded2baf4625fab0515/s3fs/core.py#L767-L784
In _mkdir we are setting by default create_parents=True which seems to be triggering to go on the elif regardless and due to the problem described in https://github.com/fsspec/filesystem_spec/issues/974 we are having conflicts.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in s3fs/core.py at _mkdir around lines 767-784 and inspect how create_parents=True selects the elif path. Read the linked filesystem_spec issue for the described conflict, then verify that re-creating an existing bucket no longer triggers that conflict with the relevant tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- aws, python
- Domain
- cloud
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100