fsspec / fsspec/s3fs

Inconsistent behavior on upload_path

Open
#595 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
1k
Forks
305
Avg merge
22h 37m
Merged PRs (30d)
4

Description

s3fs==2022.1.0
minio storage

Issue with:
upload()

my_lpath = "/temp/origin_files/"

my_rpath = 's3://mybucket/dir/'

upload_path(my_lpath, my_rpath, recursive=true)

Use case 1:
my_rpath is empty before upload, the files from my_lpath will all be placed in the my_rpath/

Use case 2:
my_rpath has files before upload, the files from my_lpath will be uploaded to my_rpath/origin_files/

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing upload_path() with the two cases described: an empty s3://mybucket/dir/ destination and one that already contains files. Compare the resulting object paths and establish the expected behavior before locating the relevant implementation and adding regression coverage. Done means the behavior is consistent for both destination states.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
cloud
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.