fsspec / fsspec/kerchunk

MultiZarrToZarr has no parameter `append` currently

Open
#513 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
366
Forks
96
Avg merge
24m
Merged PRs (30d)
1

Description

While searching for a way to merge some kerchunk references I came across https://github.com/fsspec/kerchunk/issues/479 where the append method gets called after the initial reference has been created.

As suggested by @martindurant it would be great to have append create the references itself if they do not exists, but that is currently not implemented, even if the parameters to MultiZarrToZarr suggest this.

I guess
https://github.com/fsspec/kerchunk/blob/09d7a92d82919f6d4caea3186ad090112fcabc1c/kerchunk/combine.py#L93-L95
need to be dropped for now.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Read MultiZarrToZarr in kerchunk/combine.py, especially the parameter handling around lines 93-95, and review the related kerchunk issue 479. Confirm how append is called after initial reference creation. Done means append can create the references when they do not already exist, or the misleading parameters are removed.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data-engineering
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.