fsspec / fsspec/gcsfs

test_get_put and test_get_put_recursive are skipped by CI

Open
#382 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
398
Forks
181
Avg merge
2d 10h
Merged PRs (30d)
36

Description

This makes it challenging to modify code related to getting/putting files.

See:

https://github.com/dask/gcsfs/blob/60be1b9446c70277714c2ee24b9fe2be76e9c979/gcsfs/tests/test_core.py#L461

https://github.com/dask/gcsfs/blob/60be1b9446c70277714c2ee24b9fe2be76e9c979/gcsfs/tests/test_core.py#L478

and latest CI logging:

gcsfs/tests/test_core.py::test_get_put[None] SKIPPED (async fail)        [ 43%]
gcsfs/tests/test_core.py::test_get_put[size] SKIPPED (async fail)        [ 44%]
gcsfs/tests/test_core.py::test_get_put[md5] SKIPPED (async fail)         [ 45%]
gcsfs/tests/test_core.py::test_get_put[crc32c] SKIPPED (async fail)      [ 46%]
gcsfs/tests/test_core.py::test_get_put_recursive[] SKIPPED (async fail)  [ 47%]
gcsfs/tests/test_core.py::test_get_put_recursive[gs://] SKIPPED (asy...) [ 48%]
gcsfs/tests/test_core.py::test_get_put_recursive[gcs://] SKIPPED (as...) [ 49%]
gcsfs/tests/test_core.py::test_get_put_file_in_dir[] SKIPPED (async ...) [ 50%]
gcsfs/tests/test_core.py::test_get_put_file_in_dir[gs://] SKIPPED (a...) [ 50%]
gcsfs/tests/test_core.py::test_get_put_file_in_dir[gcs://] SKIPPED (...) [ 51%]

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in gcsfs/tests/test_core.py at the referenced test_get_put and test_get_put_recursive locations, then reproduce the CI run to inspect the async-failure skips. Trace why these tests are skipped and restore their execution without breaking the related get/put tests. Done means the listed tests run rather than being skipped and pass in CI.

Written by the indexing model from the issue text.

Assessment

Tech stack
google-cloud, python
Domain
ci-cd, cloud, testing
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.