fsspec / fsspec/gcsfs

Should the default consistency for GCSFile be md5?

Open
#361 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
398
Forks
181
Avg merge
2d 10h
Merged PRs (30d)
36

Description

Composite objects in GCSFs doesn't have a md5 hash, so it kinda feels weird that the default consistency is md5 (also it never gets used since most of the operations around it is done by _open which passes the consistency as either None or the instance's consistency [defaults to also None]). Maybe it should be crc32, or None (just like the GCSFileSystem).

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the GCSFile class and its _open method, then compare its default consistency with GCSFileSystem. Determine whether composite objects require crc32 or no default consistency, and verify the chosen behavior across the operations that pass consistency explicitly.

Written by the indexing model from the issue text.

Assessment

Tech stack
google-cloud, python
Domain
cloud
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.