GCSFileSystem constructor with token=None does not try to get credentials from metadata service
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 398
- Forks
- 181
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 36
Description
Tried connect methods according to the documentation:
https://github.com/dask/gcsfs/blob/2021a89471990c58f3acaf84bd4e277c0d6c2e4d/gcsfs/core.py#L143-L146
However the methods are: https://github.com/dask/gcsfs/blob/2021a89471990c58f3acaf84bd4e277c0d6c2e4d/gcsfs/core.py#L408
The google compute metadata service is missing in the current implementation.
Suggested fix: https://github.com/dask/gcsfs/pull/263
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in gcsfs/core.py, comparing the documented connection methods around lines 143-146 with the constructor logic around line 408. Review the proposed fix in PR 263 and verify how token=None should obtain credentials from the Google Compute metadata service. Done means the documented connection path works when metadata credentials are available.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- google-cloud, python
- Domain
- cloud
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 35/100