fsspec / fsspec/filesystem_spec

Should file:// with hostname raise NotImplementedError?

Open
#998 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
1.4k
Forks
490
Avg merge
2d 3h
Merged PRs (30d)
38

Description

I was recently reminded that file: URIs can specify a hostname. If a file: URI is passed with a hostname, it is currently dropped on the floor silently.
Should something raise NotImplementedError to avoid any confusion? If so, I'm happy to create a test for this case and submit a PR.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No file or test path is named. Start by locating the Python implementation that handles file: URIs and the existing tests for URI hostnames; confirm how a hostname is currently handled, then add a regression test for the agreed NotImplementedError behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.