fsspec / fsspec/filesystem_spec

FileNotFoundError is raised when failing to access a http url

Open
#873 10 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
1.4k
Forks
490
Avg merge
2d 3h
Merged PRs (30d)
38

Description

When failing to access a http url (e.g., a network error), FileNotFoundError will be raised here: https://github.com/fsspec/filesystem_spec/blob/bdd752544ac4629deb4565103e4e42855af277a8/fsspec/implementations/http.py#L393-L397

Should this be considered a bug since FileNotFoundError is usually be used to check whether hitting a 404 error?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in fsspec/implementations/http.py at lines 393-397, then compare that error handling with the 404 handling at lines 206-207. Determine how network failures should differ from missing HTTP resources; done means the resulting exception behavior is consistent and covered by the relevant existing tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
networking
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.