fsspec / fsspec/filesystem_spec

Class-scoped fixture as instance method pytest deprecations

Open
#2,059 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
1.4k
Forks
490
Avg merge
2d 3h
Merged PRs (30d)
38

Description

some of the usages of test fixtures will be deprecated as of pytest version 9.1 and will break as of pytest version 10.0

for example:
https://github.com/fsspec/filesystem_spec/blob/65d58d4346c235747b9c2166aa60c25a3031a590/fsspec/tests/abstract/__init__.py#L21

pytest deprecations:
https://docs.pytest.org/en/stable/deprecations.html#class-scoped-fixture-as-instance-method

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Review the example in fsspec/tests/abstract/init.py around line 21 and read pytest's class-scoped fixture deprecation guidance. Find the remaining usages in the test suite, update them to the supported form, and run the relevant tests to confirm the pytest 9.1 deprecations are gone.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
testing-qa
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.