fsspec / fsspec/filesystem_spec
SMB: errors ignored when connecting
Open
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 1.4k
- Forks
- 490
- Avg merge
- 2d 3h
- Merged PRs (30d)
- 38
Description
The system tries to connect 5 times in a row, ignoring all errors. Since the for loop has no else branch, the function does not raise any error when all tentative failed.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in fsspec/implementations/smb.py around lines 123-136 and inspect the five-attempt connection loop. Check the existing SMB connection behavior and retry-related tests, if present; done means the final failed attempt surfaces an error instead of silently returning.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- networking
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100