fsspec / fsspec/filesystem_spec
DirFileSystem breaks open_async for any underling filesystem
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 1.4k
- Forks
- 490
- Avg merge
- 2d 3h
- Merged PRs (30d)
- 38
Description
DirFileSystem can wrap any async filesystem. But cause open_async method is not redirected to wrapped fs, it will always raise NotImplementedError.
As mentioned in #1411, cause all unimplemented methods in base abstract classes got no abstractmethod decorator, it's hard to see that u've missed implementation for some method.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the DirFileSystem.open_async entry point and trace how operations reach the wrapped filesystem. Confirm that async filesystems no longer encounter NotImplementedError through this wrapper, then verify the behavior with an appropriate regression test if one is available.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100