EnvProxy unit tests fail if HTTP_PROXY/HTTPS_PROXY is set
Nobody has claimed this yet.
- Dominant language
- F#
- Stars
- 2.1k
- Forks
- 528
- Avg merge
- 1d 12m
- Merged PRs (30d)
- 54
Description
If I'm behind a corporate firewall and need a proxy configured, I cannot run ./build.sh and have a single successful run.
The EnvProxy tests fail because they expect no proxy set, but end up reading from the environment (somehow) anyway.
I therefore needs two runs of ./build.sh: one with the proxy configured in the environment, so that everything is downloaded, and then one without the proxy configured, so that the tests can pass without ambient proxy settings interfering.
I have a suspicion it's because the tests override http_proxy, but not HTTP_PROXY.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the EnvProxy unit tests described in the issue and run ./build.sh with HTTP_PROXY and HTTPS_PROXY set. Check how the tests isolate http_proxy versus uppercase proxy variables. Done means the EnvProxy tests pass during a build while ambient HTTP_PROXY and HTTPS_PROXY settings are present.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- fsharp
- Domain
- cli
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100