fsprojects / fsprojects/Paket

paket restore does not fail by default on out-of-sync lock file

Open
#3,409 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
F#
Stars
2.1k
Forks
528
Avg merge
1d 12m
Merged PRs (30d)
54

Description

With an out-of-sync lock file, paket restore succeeds with return code of zero:

image

There is a flag to fail in this scenario, --fail-on-checks, but this requires opting in on every single invocation. For a large build system, this requires adding it to every paket build step definition in every codebase.

Can we make this fail by default? If there isn't something built-in already, I'd be interested in either of two possible changes:

  1. Invert the behaviour: Make it always fail by default and change the flag to --ignore-check-failures or similar.
  2. Define an environment variable that can be set to enable --fail-on-checks by default.

Thanks.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the paket restore entry point and trace how the --fail-on-checks flag affects an out-of-sync lock file. Review the existing behavior and determine whether the completed change should make failures default or provide an environment-variable alternative; done means the chosen policy is applied consistently without requiring the flag on every invocation.

Written by the indexing model from the issue text.

Assessment

Tech stack
fsharp
Domain
build-system, cli
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.