fsprojects / fsprojects/Paket

Rider OOTB experience

Open
#2,580 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug extern sdk: dotnet/sdk UX
Dominant language
F#
Stars
2.1k
Forks
528
Avg merge
1d 12m
Merged PRs (30d)
54

Description

When opening and building a solution with sdk style projects in Rider it ends up calling e.g

"C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\MSBuild\15.0\Bin\MSBuild.exe" "/property:Configuration=Debug" "/property:Platform=Any CPU" "/property:SDKToolingDirectory=C:\Program Files\dotnet" "/t:ObservableProcess" /m "C:\Projects\elastic\abstractions\src\Elasticsearch.Net.Abstractions.sln"

I removed the rider specific logging arguments to be able to run the same command on the command line. This does not attempting to restore a solution.

Rider no longer aggressively restores since the RC

https://blog.jetbrains.com/dotnet/2017/07/14/rider-release-candidate-performance-refactorings-unity/

Not sure if this is something that paket's target file needs to be resilient too or if Rider should do something here.

Visual Studio still calls a restore upon opening the solution so the Open sln file -> Build flow works OOTB there.

cc @enricosada @citizenmatt

Happy to hear your thoughts before diving in too deep!

(PS i'm all for avoiding unneeded calls to dotnet restore https://github.com/dotnet/cli/issues/6524 😄)

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the Rider build command shown in the issue and inspect Paket's target file, which is the only project entry point mentioned. Compare the restore behavior with Visual Studio's open-solution/build flow, then determine whether Paket's targets or Rider must change so SDK-style solutions build correctly without unnecessary restores.

Written by the indexing model from the issue text.

Assessment

Tech stack
fsharp
Domain
build-system, devtools
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
28/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.