fsprojects / fsprojects/Paket

convert-from-nuget parse version fail

Open
#2,159 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug nuget-convert sdk: dotnet/sdk
Dominant language
F#
Stars
2.1k
Forks
528
Avg merge
1d 12m
Merged PRs (30d)
54

Description

Description
λ» paket convert-from-nuget -f
Paket version 4.0.0-beta020
Paket failed with:
        Can't parse "1.0.*".
Input string was not in a correct format.

parsing this fsproj

<Project Sdk="FSharp.NET.Sdk;Microsoft.NET.Sdk">
  <PropertyGroup>
    <AssemblyName>Expecto</AssemblyName>
    <TargetFramework>netstandard1.6</TargetFramework>
  </PropertyGroup>
  <ItemGroup>
    <Compile Include="..\paket-files\logary\logary\src\Logary.Facade\Facade.fs" />
    <Compile Include="..\Expecto\Performance.fs" />
    <Compile Include="..\Expecto\Expecto.fs" />
    <Compile Include="..\Expecto\Expect.fs" />
  </ItemGroup>
  <ItemGroup>
    <PackageReference Include="FSharp.NET.Sdk" Version="1.0.*" PrivateAssets="All" />
    <PackageReference Include="FSharp.Core" Version="4.1.*" />
    <PackageReference Include="Argu" Version="3.3.0" />
    <PackageReference Include="Mono.Cecil" Version="0.10.0-beta2" />
    <PackageReference Include="System.Linq.Parallel" Version="4.3.0" />
    <PackageReference Include="System.Diagnostics.TraceSource" Version="4.3.0" />
    <PackageReference Include="System.Diagnostics.FileVersionInfo" Version="4.3.0" />
  </ItemGroup>
  <Import Project="..\.paket\Paket.Restore.targets" />
</Project>

parser needs to be able to handle a * and whatever else is valid for a nuget package version

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing paket convert-from-nuget -f against the shown fsproj and trace the parser handling PackageReference versions. Confirm the accepted NuGet version forms, including 1.0.*, and verify that conversion completes without the parse error.

Written by the indexing model from the issue text.

Assessment

Tech stack
fsharp
Domain
cli, tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.