fsprojects / fsprojects/Paket

Don't display unnecessary warning if no target framework is defined

Open
#1,455 20 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug needs-repro
Dominant language
F#
Stars
2.1k
Forks
528
Avg merge
1d 12m
Merged PRs (30d)
54

Description

Related to changes in fsprojects/Paket/issues/1442
The warning seems to display even when it shouldn't, we might need to be more restrictive about it.
X contains libraries, but not for the selected TargetFramework net452 in project Y

For example, I have a solution with projects that target net452, and I don't define any version or framework requirements in the dependencies file. I still get tons of warning for libraries such as Microsoft.CSharp, Microsoft.Net.Http or System.Net.Http.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the related changes in fsprojects/Paket/issues/1442 and locating the code that emits the warning text. Reproduce the case with a net452 solution whose dependencies file defines no framework requirements, then verify that warnings for libraries such as Microsoft.CSharp and System.Net.Http are no longer shown.

Written by the indexing model from the issue text.

Assessment

Tech stack
fsharp
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.