fsprojects / fsprojects/FSharpPlus

Adjust async/task/value task tests to work on net6 and on release branch

Open
#598 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

F#+ v1.1
Dominant language
F#
Stars
941
Forks
106
PR merge metrics
No merged PRs in 30d

Description

We currently see that some tests fail on the v1.6, v1.7 branch.

  • tests/FSharpPlus.Tests/ValueTask.fs the tests: testValueTaskZip, testValueTaskZipAsync
  • tests/FSharpPlus.Tests/Asyncs.fs the tests: testAsyncZip, testAsyncZipAsync
  • tests/FSharpPlus.Tests/Task.fs the tests: testTaskZip, testTaskZipAsync

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by running the named tests in tests/FSharpPlus.Tests/ValueTask.fs, Asyncs.fs, and Task.fs on net6 and the v1.6/v1.7 release branches. Compare the failures in testValueTaskZip, testValueTaskZipAsync, testAsyncZip, testAsyncZipAsync, testTaskZip, and testTaskZipAsync; done means these tests pass on the affected branches.

Written by the indexing model from the issue text.

Assessment

Tech stack
fsharp
Domain
testing-qa
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.