Clean up preprocessor directives

Open
#577 0 comments 0 reactions 1 assignee View on GitHub

@wallymathieu is already working on this.

Since Dec 17, 2023.

Assessment

This issue has not been assessed yet.

Description

F#+ v2.0

We currently have NET7_0 directives in the code base, these should be NET7 or greater rather than a specific version.

#if NET7_0

See preprocessor-directives

We have had trouble since NET?_OR_GREATER is not defined. Note the workaround in checking if not net45 et.c..

This is not a bug yet, since we have not yet released a version of F#+ compiled against a version greater than net6 (due to breaking changes in the F# compilation of assemblies).

See for instance:

#if !NET45 && !NETSTANDARD2_0 && !FABLE_COMPILER
Dominant language
F#
Stars
941
Forks
106
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from fsprojects/FSharpPlus

All issues in fsprojects/FSharpPlus

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.