fsprojects / fsprojects/FSharpPlus
Int32.TryParse and F#+ tryParse give different results
Nobody has claimed this yet.
- Dominant language
- F#
- Stars
- 941
- Forks
- 106
- PR merge metrics
- No merged PRs in 30d
Description
Description
Basically (tested with culture on en-US).
> let value: int option = tryParse "123,45";;
val value: int option = Some 12345
> Int32.TryParse "123,45";;
val it: bool * int = (false, 0)
In other words, integers cannot have thousand-separators with Int32.TryParse, but can with tryParse.
Conversely, it doesn't allow decimals, which is good:
> let value: int option = tryParse "123.45";;
val value: int option = None
> Int32.TryParse "123.45";;
val it: bool * int = (false, 0)
Likewise there's a similar difference with e-notation:
> let value: int option = tryParse "12345e4";;
val value: int option = Some 123450000
> Int32.TryParse "12345e4";;
val it: bool * int = (false, 0)
Repro steps
See above.
Expected behavior
From the description of the method, you'd expect the same behavior as the .NET functions, but they allow certain illegal values, or at least ambiguous, considering how .NET parses numbers.
Actual behavior
See above. This is caused by NumberStyles.Any, which is not used by Int32.TryParse or Decimal.TryParse. These use NumberStyles.Integer and NumberStyles.Decimal respectively (see source of .NET), which limit the allowed range.
Known workarounds
Create your own types or call Int32.TryParse directly, or create your own helper function.
Related information
Most recent F#+ and tested with .NET 6, but assuming it is the same on .NET 7.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the F#+ tryParse entry point and reproduce the reported en-US cases, comparing them with .NET Int32.TryParse and Decimal.TryParse. Check the NumberStyles.Any behavior described in the issue; done means tryParse follows the corresponding .NET parsing behavior while preserving the stated decimal rejection.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- fsharp
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100