fsprojects / fsprojects/FSharpPlus
Array.replace takes in seq for its two first values instead of arrays
Open
Nobody has claimed this yet.
breaking change
F#+ v1.1
F#+ v2.0
- Dominant language
- F#
- Stars
- 941
- Forks
- 106
- PR merge metrics
- No merged PRs in 30d
Description
See for instance: https://github.com/fsprojects/FSharpPlus/pull/513#discussion_r1020880618
This has been done by reverting the type signature fix on the F#+ 1.x branches : See #303
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the Array.replace type signature and the discussion in PR #513, then compare the 1.x branch changes referenced by #303. Confirm which two leading parameters currently accept seq rather than arrays, and check the related tests or examples. Done means the signature and coverage consistently require arrays.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- fsharp
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100