fsprojects / fsprojects/FSharpPlus
Validation.ofResult doesn't require Semigroup
Open
Nobody has claimed this yet.
enhancement
- Dominant language
- F#
- Stars
- 941
- Forks
- 106
- PR merge metrics
- No merged PRs in 30d
Description
When converting from Result<'T, 'TError> to Validation<'TError, 'T> we need to either:
- Make sure
'TErroris a Semigroup (this simply means that the type is additive) - Transform to a Semigroup
I'm not sure what's the best way to go, maybe the best backward compatibility way is to add a static constraint to .ofResult
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at Validation.ofResult and trace the Result-to-Validation conversion and its type constraints. Decide how the TError Semigroup requirement should be handled, then verify that the chosen approach preserves the intended backward compatibility.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- fsharp
- Domain
- api
- Issue type
- Bug
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100