fsprojects / fsprojects/FSharpPlus
toSeq defaults
Nobody has claimed this yet.
- Dominant language
- F#
- Stars
- 941
- Forks
- 106
- PR merge metrics
- No merged PRs in 30d
Description
ToSeq Invokable has an overload for IEnumerable which has lower priority than the custom implementation (ToSeq explicitly defined on the type).
This cause some inconsistencies, in dictionary like types where toSeq doesn't give back the same as [type].toSeq.
However fixing this is technically a breaking change, we might have to wait for v2
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the ToSeq Invokable's IEnumerable overload and the custom ToSeq implementation described in the issue. Compare toSeq with [type].toSeq for dictionary-like types, then assess whether changing overload priority is acceptable for the proposed v2. Done means the behavior and breaking-change decision are clearly established.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- fsharp
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100