fsprojects / fsprojects/FSharpPlus

Add more string functions - culture-sensitive functions

Open
#165 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

RFC
Dominant language
F#
Stars
941
Forks
106
PR merge metrics
No merged PRs in 30d

Description

Description

https://github.com/fsprojects/FSharpPlus/issues/158#issuecomment-512721780

Regarding the functions taking a culture as parameter, I propose also to discuss them in a different issue, because I think they need more in depth study as I can't find a good proposal at the moment. So let's move them to another issue in order to speed up this one.

"culture-sensitive functions" are functions taking CultureInfo as s parameter.

Candidates
  • Compare
  • ToLower / ToUpper
  • StartsWith / EndsWith
  • (add more if something is missing)
Ideas
  • adding suffix like WithCulture
  • using functor(a la OCaml)-like dependency injection
  • to be discussed

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the linked FSharpPlus issue #158 comment and the existing string-function API, then compare the listed CultureInfo candidates and possible naming or dependency-injection approaches. Done means reaching an agreed design for culture-sensitive functions and implementing the selected API consistently, with any missing candidates identified.

Written by the indexing model from the issue text.

Assessment

Tech stack
fsharp
Domain
tooling
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.