fsprojects / fsprojects/FSharpLint
bug: AvoidSinglePipeOperator false negative
Open
Nobody has claimed this yet.
- Dominant language
- F#
- Stars
- 327
- Forks
- 74
- PR merge metrics
- No merged PRs in 30d
Description
From FSharpLint codebase itself (src/FSharpLint.Core/Rules/Conventions/DisallowShadowing.fs):
let extractIdentifiersFromSimplePats (simplePats: SynSimplePats) : List<Ident> =
match simplePats with
| SynSimplePats.SimplePats(patterns, _, _) ->
patterns |> List.map extractIdentifier
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with src/FSharpLint.Core/Rules/Conventions/DisallowShadowing.fs and inspect how extractIdentifiersFromSimplePats handles the shown pipeline expression. Reproduce the AvoidSinglePipeOperator false negative and verify that the rule detects this code when the fix is complete.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- fsharp
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100