fsprojects / fsprojects/FSharpLint
Is the 'deployReleaseBinaries' CI build step supposed to run the unit tests 3 times?
Nobody has claimed this yet.
- Dominant language
- F#
- Stars
- 327
- Forks
- 74
- PR merge metrics
- No merged PRs in 30d
Description
This is just an observation after looking at the current build issues rather than a bug, but I'm putting it in its own issue rather than just in a comment in an unrelated PR:
Looking at the CI build logs, it looks like the deployReleaseBinaries CI stage is running the unit tests 3 times -
Once in the 'build' step - https://github.com/fsprojects/FSharpLint/actions/runs/19330699804/job/55293390736#step:4:55
Then again in the 'pack' step - https://github.com/fsprojects/FSharpLint/actions/runs/19330699804/job/55293390736#step:5:68
Then a 3rd time in the 'upload binaries to nuget' step - https://github.com/fsprojects/FSharpLint/actions/runs/19330699804/job/55293390736#step:8:64
This seems a tad spurious, and also looks like it adds several minutes to the build times?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the linked deployReleaseBinaries CI run, then locate the GitHub Actions workflow definition for its build, pack, and upload binaries to nuget steps. Check whether each step invokes the F# unit tests; done means determining whether the three runs are intentional and, if not, removing redundant executions without losing required checks.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- fsharp, github-actions
- Domain
- ci-cd
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 42/100