FL0035: False positive with Active Patterns
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 42/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- fsharp
- Domain
- tooling
Research direction
No source file or test is named. Start by locating the FL0035 rule and reproducing the provided active-pattern example in F# Lint 0.5.2; compare it with a case where the rule should apply. Done means the example no longer produces an FL0035 diagnostic and regression coverage verifies that behavior.
Written by the indexing model from the issue text.
Description
Description
Composition cannot be applied (or I couldn't figure out how to) for Active Patterns so FL0035 should not be raised.
Repro steps
let (|Something|_|) (l: int list option) =
l |> Option.map (fun x -> Something (System.Collections.ObjectModel.ObservableCollection x)) // FL0035 FP
Expected behavior
No issue raised.
Actual behavior
FL0035 is raised.
Known workarounds
Don't know.
Related information
- Operating system: Windows 10
- Branch: F# Lint 0.5.2
- .NET Runtime, CoreCLR or Mono Version: .net 48
- Dominant language
- F#
- Stars
- 327
- Forks
- 74
- PR merge metrics
- No merged PRs in 30d
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from fsprojects/FSharpLint
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
fsprojects/FSharpLint#869 · 2 comments ·
-
Repo Assist? Open
Difficulty 5/5 Over a week Newbie friendliness 20/100
fsprojects/FSharpLint#849 · 2 comments ·
-
Difficulty 4/5 3-5 days Newbie friendliness 38/100
fsprojects/FSharpLint#840 · 7 comments · 2 reactions ·
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
fsprojects/FSharpLint#838 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 45/100
fsprojects/FSharpLint#836 ·
All issues in fsprojects/FSharpLint
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
bancolombia/sentinel#20 ·
-
optimization optimization:agents-md-curator
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
githubnext/gh-aw-cao#13143 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
-
chore
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
alunduil/woodland-generators#669 ·
-
area: tooling
Difficulty 2/5 1-3 hours Newbie friendliness 86/100