Should not suggest composition over lambdas like `fun x -> -sin x`

Open
#372 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
25/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
fsharp
Domain
tooling

Research direction

Start by reproducing the issue with the sampleEnergy lambda shown in the report and trace which lint rule recommends composition. The issue names no source file, entry point, or test, so locate the relevant rule and its existing tests first. Done means the lambda is no longer flagged while the rule's other behavior remains covered.

Written by the indexing model from the issue text.

Description

enhancement
Description

FSharpLint suggests I should replace lambda expression like fun x -> -sin x with composition, which makes a much less legible code (like sin >> ((*) -1.) or sin >> (~-)).

Repro steps

Define a lambda like

let sampleEnergy= (fun x -> -sin x)
Expected behavior

FSharpLint should accept the existing lambda expression as it is.

Dominant language
F#
Stars
327
Forks
74
PR merge metrics
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from fsprojects/FSharpLint

All issues in fsprojects/FSharpLint

Similar issues

More DevTools issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.