[repo-assist] eng: align CI dotnet matrix with global.json SDK pin; document 8.12.0 release notes

Open
#537 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
55/100
Issue type
Documentation
Clarity
Clearly specified
Activity status
Active
Tech stack
fsharp, github-actions

Research direction

Compare the dotnet-version entries in .github/workflows/pr.yml and .github/workflows/push.yml with the SDK pin in global.json, then inspect the existing format in RELEASE_NOTES.md. Confirm the four listed PRs and add the 8.12.0 release entry, align both workflow versions, and run dotnet test tests/FSharp.TypeProviders.SDK.Tests.fsproj -c Release.

Written by the indexing model from the issue text.

Description

agentic-workflows automation repo-assist

🤖 This is an automated pull request from Repo Assist, an AI assistant. Please review carefully before merging.

Summary

  • Eng: Align the CI workflow dotnet matrix version (8.0.1248.0.125) in pr.yml and push.yml with the global.json SDK pin. The 8.11.0 release notes documented the global.json bump to 8.0.125, but the CI matrix version was not updated to match at the time.
  • Docs: Add a RELEASE_NOTES.md entry for 8.12.0 summarizing four PRs merged since 8.11.0 that were not yet documented in a release entry: #520 (perf: stop re-deserializing CodeGenerator quotation patterns per member body), #525/#526 (thread safety for varTable/assemblyTable), #523 (fix invalid IL for generative methods with System.Void return type), and #532 (document agentic contribution workflow in CONTRIBUTING.md).

Rationale

Keeping the CI matrix's pinned dotnet-version aligned with global.json avoids confusion about which SDK patch version CI actually exercises, and ensures CI stays consistent with local/agent build environments. The RELEASE_NOTES.md update is bookkeeping to keep the changelog current with what has actually landed on master.

Trade-offs

  • Purely a CI-config and changelog documentation change — no functional/behavioral changes to the SDK itself.
  • Left as a draft PR per Repo Assist convention for maintainer review.
  • Note: PR #535 (an earlier Repo Assist attempt at 8.12.0 release prep) also touches RELEASE_NOTES.md and global.json; that PR could not be pushed automatically because global.json is a protected file. This PR does not modify global.json and can proceed independently; the RELEASE_NOTES.md content here supersedes/duplicates the equivalent section proposed there, so maintainers may wish to close #535 in favor of this PR plus a separate manual global.json bump if desired.

Test Status

  • dotnet test tests/FSharp.TypeProviders.SDK.Tests.fsproj -c Release: Passed — 165/165 tests, 0 failures, 0 skipped (net8.0)
  • ./build.sh RunTests (FAKE) was not used because FAKE's RunTests target requires resolving the SDK's runtime pack list over the network, which is blocked by the sandbox proxy (403) in this environment. dotnet test was used directly as a reliable substitute and passed cleanly.

[!WARNING]
Protected Files — Push Permission Denied

This was originally intended as a pull request, but the patch modifies protected files. A human must create the pull request manually.

Protected files

The push was rejected because GitHub Actions does not have workflows permission to push these changes, and is never allowed to make such changes, or other authorization being used does not have this permission.

Create the pull request manually
# Download the patch from the workflow run
gh run download 34439028666 -n agent -D /tmp/agent-34439028666

# Create a new branch
git checkout -b repo-assist/eng-ci-dotnet-version-release-notes-20260910-e6fbb08f3acddfc5 master

# Apply the patch (--3way handles cross-repo patches)
git am --3way /tmp/agent-34439028666/aw-repo-assist-eng-ci-dotnet-version-release-notes-20260910.patch

# Push the branch and create the pull request
git push origin repo-assist/eng-ci-dotnet-version-release-notes-20260910-e6fbb08f3acddfc5
gh pr create --title '[repo-assist] eng: align CI dotnet matrix with global.json SDK pin; document 8.12.0 release notes' --base master --head repo-assist/eng-ci-dotnet-version-release-notes-20260910-e6fbb08f3acddfc5 --repo fsprojects/FSharp.TypeProviders.SDK

Generated by 🌈 Repo Assist, see workflow run. Learn more.
Comment /repo-assist to run again

Add this agentic workflow to your repo

To install this agentic workflow, run

gh aw add githubnext/agentics/workflows/repo-assist.md@ae8d551f07c7ed7619f8c58c7bb4c3ac89395d38
Dominant language
F#
Stars
304
Forks
91
Avg merge
56m
Merged PRs (30d)
1

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from fsprojects/FSharp.TypeProviders.SDK

All issues in fsprojects/FSharp.TypeProviders.SDK

Similar issues

More DevOps issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.