fsprojects / fsprojects/FSharp.Data.SqlClient
Option not inferred for optional sproc parameters of type binary and nvarchar
Open
Nobody has claimed this yet.
bug
- Dominant language
- F#
- Stars
- 206
- Forks
- 66
- PR merge metrics
- No merged PRs in 30d
Description
Description
SqlClient does not infer the correct optionality for all stored procedure parameters.
For example, given this sproc with three optional parameters
CREATE PROCEDURE [dbo].[Procedure1]
@param1 int = NULL,
@param2 nvarchar(10) = NULL,
@param3 binary(10) = NULL
AS
SELECT 1
only the first one is inferred to be optional:
Note however that the type signature seems correct:
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the stored procedure example and inspect how SqlClient infers parameter optionality from SQL Server metadata. Compare the int, nvarchar, and binary parameters; the issue is done when all three parameters with NULL defaults are reported as optional and the existing type signatures remain correct.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- fsharp, sql
- Domain
- database
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100