fsprojects / fsprojects/FSharp.Data.SqlClient

Needs an AllParametersOptional on SqlProgrammabilityProvider or?

Open
#265 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

improvement up-for-grabs
Dominant language
F#
Stars
206
Forks
66
PR merge metrics
No merged PRs in 30d

Description

I'm trying to call a stored procedure but many parameters should allow null.

I think a top level AllParameterOptionals parameter could be a good short term solution.

Longer term, I'd like the library to not hardcode so many parameters at the top level, but closer to usage level as method static parameters (supported since F# 4) to Execute/ExecuteAsync:

  • ResultType
  • AllParametersOptional

It is not healthy to generate a matrix of SqlProgrammabilityProvider instanciations and have developer to pick the correct one, as we will add more top level options, the problem will get worse.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the SqlProgrammabilityProvider API and tracing how its parameters reach Execute and ExecuteAsync. Compare the proposed AllParametersOptional option with the existing top-level options and assess the alternative of method static parameters. Done means the API direction and handling of nullable stored-procedure parameters are defined and covered by the relevant tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
fsharp, sql
Domain
databases
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.