fsprojects / fsprojects/FSharp.Data.SqlClient
Remove "Provider" post-fix.
Nobody has claimed this yet.
- Dominant language
- F#
- Stars
- 206
- Forks
- 66
- PR merge metrics
- No merged PRs in 30d
Description
SqlCommandProvider -> SqlCommand
SqlEnumProvider -> SqlEnum
"Provider" post-fix is noise and was used initially mostly because lack of TP dev experience.
This will be BREAKING CHANGE.
The first rename can create naming conflict problem when both .NET BCL System.Data.SqlClient and FSharp.Data namespaces are open. Workarounds:
- Use full type name e.g.
let cmd = new System.Data.SqlClient.SqlCommand() - Use type alias for BCL types from System.Data.SqlClient
Overall feels like not a big deal because it's very rare that both raw ADO.NET and FSharp.Data.SqlClient used intensively in a same file.
P.S.
SqlProgrammabilityProvider becomes SqlClient. See issue #161
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the declarations and usages of SqlCommandProvider and SqlEnumProvider, then review issue #161 for the related SqlProgrammabilityProvider rename. Rename the specified public types and update every affected reference, checking that the documented System.Data.SqlClient naming conflict remains understood; done means the old names are no longer used and the project still builds.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- fsharp, sql
- Domain
- databases
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100