fslabs / fslabs/fslabscli

`fix-lock-files --check` doesn't fail when it should, just leaves a diff

Open
#294 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
5
Forks
1
Avg merge
17h 48m
Merged PRs (30d)
2

Description

I'm trying to run cargo fslabscli fix-lock-files --check on the main branch of fsl_libs right now, and it succeeds while producing a diff.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by running cargo fslabscli fix-lock-files --check on the main branch of fsl_libs and inspect the diff it produces. Trace the check command's exit status and make it fail when the command would leave a diff, then verify that the command reports failure in this case.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
cli
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.