fslabs / fslabs/fslabscli

Better error handling

Open
#238 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
5
Forks
1
Avg merge
17h 48m
Merged PRs (30d)
2

Description

For example do_test_on_package does not return a Result, but instead it just manages a failed bool and keeps running through the code without early returns. We end up with sub-standard error reporting where the process fails and just prints:

ERROR cargo_fslabscli: Could not execute command: tests failed

Even with -vvvv that's all we get.

We should do some refactoring to make sure errors are not dropped so quickly.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating do_test_on_package and tracing how its failed boolean is propagated to the final "tests failed" error. Identify where the underlying command errors are discarded; done means failures preserve useful underlying error details instead of only reporting that tests failed.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
cli
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.