fsharp / fsharp/fslang-suggestions

Support DisposeAsync in async computation expression

Open
#866 26 comments 27 reactions 0 assignees View on GitHub
approved-in-principle area: async-and-tasks
Dominant language
No language data
Stars
373
Forks
21
PR merge metrics
No merged PRs in 30d

Description

# Support DisposeAsync in async/task computation expression

I propose we add support for the IAsyncDisposable interface in async computation.
The addition of a new keyword `use!` seems a little bit weird because it would be only for async builder. I suppose we could try to implement it in the current `Using` method of the builder

The existing way of approaching this problem in F# is calling the DisposeAsync manually and handling the error case by hands.

## Pros and Cons

The advantages of making this adjustment to F# are ...
If IAsyncDisposable interface is available we should use it instead of the synchronous one.
The usage of StreamWriter on AspNet Core (3.x) reponse body with the keyword `use` will raise exception due to synchronous flush

> ASP.NET Core : Synchronous operations are disallowed. Call FlushAsync or set AllowSynchronousIO to true instead

The disadvantages of making this adjustment to F# are ..
Don't see any

## Extra information

Estimated cost (XS, S, M, L, XL, XXL): S

Related suggestions: (put links to related suggestions here)

## Affidavit (please submit!)

Please tick this by placing a cross in the box:
* [x] This is not a question (e.g. like one you might ask on [stackoverflow](http://stackoverflow.com)) and I have searched stackoverflow for discussions of this issue
* [x] I have [searched both open and closed suggestions on this site](http://github.com/fsharp/fslang-suggestions/issues) and believe this is not a duplicate
* [x] This is not something which has obviously "already been decided" in previous versions of F#. If you're questioning a fundamental design decision that has obviously already been taken (e.g. "Make F# untyped") then please don't submit it.

Please tick all that apply:
* [x] This is not a breaking change to the F# language design
* [x] I or my company would be willing to help implement and/or test this

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.